[GitHub] [kafka] cmccabe commented on a change in pull request #10504: KAFKA-12620 Allocate producer ids on the controller

[GitBox]

cmccabe commented on a change in pull request #10504:
URL: https://github.com/apache/kafka/pull/10504#discussion_r635585021



##########
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##########
@@ -330,10 +332,21 @@ class KafkaServer(
         groupCoordinator = GroupCoordinator(config, replicaManager, 
Time.SYSTEM, metrics)
         groupCoordinator.startup(() => 
zkClient.getTopicPartitionCount(Topic.GROUP_METADATA_TOPIC_NAME).getOrElse(config.offsetsTopicPartitions))
 
+        /* create producer ids manager */
+        val producerIdManager = if 
(config.interBrokerProtocolVersion.isAllocateProducerIdsSupported) {
+          ProducerIdGenerator(

Review comment:
       It seems a bit weird that both function calls both have the same name. 
Can't we just create the subclass we want directly here, for clarity? One is 
ZkWhatever, the other is RpcWhatever, etc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org