cmccabe commented on a change in pull request #10572:
URL: https://github.com/apache/kafka/pull/10572#discussion_r636531195
##########
File path:
metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java
##########
@@ -252,6 +252,73 @@ public void testGlobalTopicAndPartitionMetrics() throws
Exception {
assertEquals(0, ctx.metrics.globalPartitionCount());
}
+ @Test
+ public void testOfflinePartitionAndReplicaImbalanceMetrics() throws
Exception {
+ ReplicationControlTestContext ctx = new
ReplicationControlTestContext();
+ ReplicationControlManager replicationControl = ctx.replicationControl;
+
+ for (int i = 0; i < 4; i++) {
+ registerBroker(i, ctx);
+ unfenceBroker(i, ctx);
+ }
+
+ CreatableTopicResult foo = ctx.createTestTopic("foo",
Review comment:
This is definitely a nitpick, but can you put this one fewer lines? 2
lines should be enough for this. Same for the ones below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
