showuon commented on a change in pull request #10741:
URL: https://github.com/apache/kafka/pull/10741#discussion_r636602191
##########
File path:
clients/src/main/java/org/apache/kafka/common/errors/InvalidConfigurationException.java
##########
@@ -16,6 +16,9 @@
*/
package org.apache.kafka.common.errors;
+/**
+ * Indicates an error condition where the specified configuration is not valid
Review comment:
`nit`: this one and the following sentences are missing subject, i.e.
**This exception** indicates an error.... Is it intended?
##########
File path:
clients/src/main/java/org/apache/kafka/common/errors/ConcurrentTransactionsException.java
##########
@@ -16,6 +16,12 @@
*/
package org.apache.kafka.common.errors;
+/**
+ * This exception indicates that a concurrent exception has occurred.
+ *
+ * The producer attempted to update a transaction while
Review comment:
I think `concurrent exception has occurred` is not clear enough. Could
we just say: `This exception indicates that the producer attempted to update a
transaction while another concurrent operation on the same transaction was
ongoing.` ?
##########
File path:
clients/src/main/java/org/apache/kafka/common/errors/GroupSubscribedToTopicException.java
##########
@@ -16,6 +16,11 @@
*/
package org.apache.kafka.common.errors;
+/**
+ * Deleting offsets of a topic is forbidden while the consumer group is
actively subscribed to it
+ *
+ * This exception is thrown in the event of such occurrence
Review comment:
`nit`: could we make this 2 sentences into 1 like others? ex: `This
exception is in the event of deleting offsets of a topic....` ?
##########
File path:
clients/src/main/java/org/apache/kafka/common/errors/MemberIdRequiredException.java
##########
@@ -16,6 +16,11 @@
*/
package org.apache.kafka.common.errors;
+/**
+ * The group member needs to have a valid member id before actually entering a
consumer group
+ *
+ * This exception is generated when this is not the case
Review comment:
`nit`: as above, could we make these 2 sentences into 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
