[GitHub] [kafka] junrao commented on a change in pull request #10742: MINOR: Add log identifier/prefix printing in Log layer static functions

[GitBox]

junrao commented on a change in pull request #10742:
URL: https://github.com/apache/kafka/pull/10742#discussion_r637236996



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2005,7 +2005,7 @@ object Log extends Logging {
     Files.createDirectories(dir.toPath)
     val topicPartition = Log.parseTopicPartitionName(dir)
     val segments = new LogSegments(topicPartition)
-    val leaderEpochCache = Log.maybeCreateLeaderEpochCache(dir, 
topicPartition, logDirFailureChannel, config.messageFormatVersion.recordVersion)
+    val leaderEpochCache = Log.maybeCreateLeaderEpochCache(dir, 
topicPartition, logDirFailureChannel, 
config.messageFormatVersion.recordVersion, this.logIdent)

Review comment:
       Hmm, it seems that `this.logIdent` is always empty?

##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2332,7 +2336,8 @@ object Log extends Logging {
           config,
           scheduler,
           logDirFailureChannel,
-          producerStateManager)
+          producerStateManager,
+          logPrefix)

Review comment:
       Could we add the new param to javadoc?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org