[GitHub] [kafka] ijuma commented on a change in pull request #10757: MINOR: Log more information when producer snapshot is written

[GitBox]

ijuma commented on a change in pull request #10757:
URL: https://github.com/apache/kafka/pull/10757#discussion_r638803061



##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2011,7 +2011,11 @@ object Log extends Logging {
       logDirFailureChannel,
       config.messageFormatVersion.recordVersion,
       s"[Log partition=$topicPartition, dir=${dir.getParent}] ")
-    val producerStateManager = new ProducerStateManager(topicPartition, dir, 
maxProducerIdExpirationMs)
+    val producerStateManager = new ProducerStateManager(
+      topicPartition,
+      dir,
+      maxProducerIdExpirationMs,
+      time)

Review comment:
       Nit: is this really easier to read than just adding the `time` parameter 
in the same line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org