ableegoldman commented on a change in pull request #10755:
URL: https://github.com/apache/kafka/pull/10755#discussion_r639351170
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/TaskMetadata.java
##########
@@ -40,6 +40,18 @@
private final Optional<Long> timeCurrentIdlingStarted;
+ /**
+ * @deprecated since 3.0, please use {@link #TaskMetadata(TaskId, Set,
Map, Map, Optional) instead}
+ */
+ @Deprecated
+ public TaskMetadata(final String taskId,
+ final Set<TopicPartition> topicPartitions,
+ final Map<TopicPartition, Long> committedOffsets,
+ final Map<TopicPartition, Long> endOffsets,
+ final Optional<Long> timeCurrentIdlingStarted) {
+ this(TaskId.parse(taskId), topicPartitions, committedOffsets,
endOffsets, timeCurrentIdlingStarted);
+ }
+
public TaskMetadata(final TaskId taskId,
Review comment:
Well, we would still need a public constructor no matter what even with
an internal impl class. I'll add a comment to clarify that it's not intended
for public use and maybe file a followup ticket to migrate this to an interface
in case someone wants to get into that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
