[GitHub] [kafka] cmccabe commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

[GitBox]

cmccabe commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639922279



##########
File path: 
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##########
@@ -259,6 +260,10 @@ class BrokerMetadataListener(
     clientQuotaManager.handleQuotaRecord(record)
   }
 
+  def handleProducerIdRecord(record: ProducerIdsRecord): Unit = {
+    // no-op

Review comment:
       Can you add a short description of why this is a no-op? For example, 
"Brokers get their IDs from the RPC, so we don't need this" or something like 
that. Otherwise it looks like a TODO (I know that's not the intention)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org