vvcephei commented on a change in pull request #10744:
URL: https://github.com/apache/kafka/pull/10744#discussion_r640840509
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java
##########
@@ -24,14 +24,14 @@
import static
org.apache.kafka.streams.kstream.internals.WrappingNullableUtils.prepareKeySerializer;
import static
org.apache.kafka.streams.kstream.internals.WrappingNullableUtils.prepareValueSerializer;
-public class SinkNode<KIn, VIn, KOut, VOut> extends ProcessorNode<KIn, VIn,
KOut, VOut> {
+public class SinkNode<KIn, VIn> extends ProcessorNode<KIn, VIn, Void, Void> {
Review comment:
We already throw an exception if you try and add a child. I think it
would complicate any of our processor graph traversal algorithms if we made it
illegal to even call getChildren, as they would have to type-check the nodes
before traversing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
