[GitHub] [kafka] ijuma commented on pull request #9229: MINOR: Reduce allocations in requests via buffer caching

[GitBox]

ijuma commented on pull request #9229:
URL: https://github.com/apache/kafka/pull/9229#issuecomment-851047311


   The results are similar for the ducktape benchmarks since the bottleneck is 
elsewhere. In the PR description, I include the results for a workload that 
shows significant improvement with these changes. Also, the following 
allocation profiles show that the the lz4 buffer allocations dominate trunk and 
are gone in this PR:
   
   trunk:
   
![image](https://user-images.githubusercontent.com/24747/120117066-310dfc80-c140-11eb-8ad4-490e749e2162.png)
   
   this PR:
   
![image](https://user-images.githubusercontent.com/24747/120117071-4b47da80-c140-11eb-9292-8dc586215245.png)
   
   So, I think we can go ahead and merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org