showuon commented on a change in pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#discussion_r644562533



##########
File path: 
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
##########
@@ -151,7 +148,7 @@ class ReassignPartitionsIntegrationTest extends 
ZooKeeperTestHarness {
       
"""{"topic":"bar","partition":0,"replicas":[3,2,0],"log_dirs":["any","any","any"]}"""
 +
       """]}"""
     // Execute the assignment
-    runExecuteAssignment(zkClient, assignment, -1L)
+    runExecuteAssignment(cluster.adminClient, false, assignment, -1L, -1L)

Review comment:
       Nice catch! The test should also be removed since there's already a test 
`testReassignment` to test adminClient reassignment. Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to