[ 
https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356273#comment-17356273
 ] 

Bruno Cadonna commented on KAFKA-9168:
--------------------------------------

Hi [~sagarrao], our internal benchmark did not show any significant performance 
improvements (i.e.. throughput improvements). I left some comments on your PR. 
I think the best thing to move forward here would be to implement a simple 
Kafka Streams app with which you can experiment different usages of the direct 
buffer for different operations on the RocksDB state stores. Then if you have 
found some good use cases for the direct buffers that improve performance in 
Streams, we can run our internal benchmarks again and verify if we see the 
improvements also there. WDYT? 

> Integrate JNI direct buffer support to RocksDBStore
> ---------------------------------------------------
>
>                 Key: KAFKA-9168
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9168
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Sagar Rao
>            Assignee: Sagar Rao
>            Priority: Major
>              Labels: perfomance
>
> There has been a PR created on rocksdb Java client to support direct 
> ByteBuffers in Java. We can look at integrating it whenever it gets merged. 
> Link to PR: [https://github.com/facebook/rocksdb/pull/2283]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to