ijuma commented on a change in pull request #10471:
URL: https://github.com/apache/kafka/pull/10471#discussion_r644793036



##########
File path: 
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala
##########
@@ -128,11 +126,10 @@ class ReassignPartitionsIntegrationTest extends 
ZooKeeperTestHarness {
         PartitionReassignmentState(Seq(3, 2, 0), Seq(3, 2, 0), true)
     )
 
-    // When using --zookeeper, we aren't able to see the new-style assignment

Review comment:
       Yeah, I don't know what it means by new-style assignment either.

##########
File path: docs/upgrade.html
##########
@@ -43,7 +43,8 @@ <h5><a id="upgrade_300_notable" 
href="#upgrade_300_notable">Notable changes in 3
             <code>AclBindingFilter</code>.</li>
         <li>The <code>Admin.electedPreferredLeaders()</code> methods were 
removed. Please use <code>Admin.electLeaders</code> instead.</li>
         <li>The <code>kafka-preferred-replica-election</code> command line 
tool was removed. Please use <code>kafka-leader-election</code> instead.</li>
-        <li>The <code>--zookeeper</code> option was removed from the 
<code>bin/kafka-topics.sh</code> command line tool. Please use 
<code>--bootstrap-server</code> instead.</li>
+        <li>The <code>--zookeeper</code> option was removed from the 
<code>bin/kafka-topics.sh</code> and 
<code>bin/kafka-reassign-partitions.sh</code> command line tool.

Review comment:
       "command line tool" -> "command line tools"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to