cadonna commented on a change in pull request #10428:
URL: https://github.com/apache/kafka/pull/10428#discussion_r644711679
##########
File path: core/src/main/java/kafka/metrics/FilteringJmxReporter.java
##########
@@ -51,7 +50,7 @@ public void updatePredicate(Predicate<MetricName> predicate) {
} else {
super.onMetricRemoved(name);
}
- }
- );
+ });
}
+
Review comment:
@dongjinleekr The empty lines at the end of the class are still there
although you removed the formatting directive. Maybe it is the default
behavior. Could you try to add it again and set the value to 0?
##########
File path: core/src/test/java/kafka/test/MockController.java
##########
@@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource
resource,
}
@Override
- public CompletableFuture<AlterPartitionReassignmentsResponseData>
- alterPartitionReassignments(AlterPartitionReassignmentsRequestData
request) {
+ public CompletableFuture<AlterPartitionReassignmentsResponseData>
alterPartitionReassignments(AlterPartitionReassignmentsRequestData request) {
throw new UnsupportedOperationException();
}
@Override
- public CompletableFuture<ListPartitionReassignmentsResponseData>
- listPartitionReassignments(ListPartitionReassignmentsRequestData
request) {
+ public CompletableFuture<ListPartitionReassignmentsResponseData>
listPartitionReassignments(ListPartitionReassignmentsRequestData request) {
throw new UnsupportedOperationException();
}
@Override
public CompletableFuture<Map<ConfigResource, ApiError>> legacyAlterConfigs(
- Map<ConfigResource, Map<String, String>> newConfigs, boolean
validateOnly) {
+
Map<ConfigResource, Map<String, String>> newConfigs, boolean validateOnly) {
Review comment:
One question here. If you put the parameters of this method on the same
line as the method name and you run again the formatter, will the parameters
stay on the same line as the method name?
What would happen if you put the first parameter on the same line as the
method name and then put each of the remaining parameters on its line own line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
