[GitHub] [kafka] ijuma commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

[GitBox]

ijuma commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r645318499



##########
File path: build.gradle
##########
@@ -829,6 +829,7 @@ project(':core') {
     testImplementation(libs.jfreechart) {
       exclude group: 'junit', module: 'junit'
     }
+    testImplementation libs.mockitoInline // supports mocking static methods, 
final classes, etc.

Review comment:
       Do we really need this?

##########
File path: build.gradle
##########
@@ -829,6 +829,7 @@ project(':core') {
     testImplementation(libs.jfreechart) {
       exclude group: 'junit', module: 'junit'
     }
+    testImplementation libs.mockitoInline // supports mocking static methods, 
final classes, etc.

Review comment:
       Mocking static methods is not ideal, so we should only do it as a last 
resort.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org