rondagostino commented on pull request #10828: URL: https://github.com/apache/kafka/pull/10828#issuecomment-855972789
@ijuma The relevant KRaft PRs are https://github.com/apache/kafka/pull/10039 and https://github.com/apache/kafka/pull/10005 (more the latter than the former, though). I believe this behavior did not change with respect to what is retrieved via `val config = fetchLogConfig(topicPartition.topic)`; I think originally the code would invoke the config provider, which was defined like this: ``` val configProvider = new TopicConfigFetcher { override def fetch(): Properties = { val adminZkClient = new AdminZkClient(replicaManager.zkClient) adminZkClient.fetchEntityConfig(ConfigType.Topic, topicPartition.topic) } } ``` Now it just asks the config repository for the topic config. And then, regardless of what it got, whether via `val props = topicConfigProvider.fetch()` or `val props = configRepository.topicConfig(topic)`, it would invoke this to get the LogConfig: ``` LogConfig.fromProps(logManager.currentDefaultConfig.originals, props) ``` And then when it logged it it was always invoking `config.originals.asScala.mkString(", ")`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
