mdedetrich opened a new pull request #10839:
URL: https://github.com/apache/kafka/pull/10839


   This PR makes all of the Scala's `case class`'s final to ensure correctness 
of Kafka's Scala code that uses these case classes. In Scala its best practice 
to make `case class`'s final since `case class` automatically generates 
critical methods such as `hashcode`/`equals`/`unapply` which can break code if 
user's override these methods by subclassing.
   
   Please see the 
[KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-754%3A+Make+Scala+case+class%27s+final)
 for more info.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to