ijuma commented on a change in pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#discussion_r647474072
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -402,43 +402,43 @@ object KafkaConfig {
val RackProp = "broker.rack"
/** ********* Log Configuration ***********/
val NumPartitionsProp = "num.partitions"
- val LogDirsProp = "log.dirs"
- val LogDirProp = "log.dir"
- val LogSegmentBytesProp = "log.segment.bytes"
-
- val LogRollTimeMillisProp = "log.roll.ms"
- val LogRollTimeHoursProp = "log.roll.hours"
-
- val LogRollTimeJitterMillisProp = "log.roll.jitter.ms"
- val LogRollTimeJitterHoursProp = "log.roll.jitter.hours"
-
- val LogRetentionTimeMillisProp = "log.retention.ms"
- val LogRetentionTimeMinutesProp = "log.retention.minutes"
- val LogRetentionTimeHoursProp = "log.retention.hours"
-
- val LogRetentionBytesProp = "log.retention.bytes"
- val LogCleanupIntervalMsProp = "log.retention.check.interval.ms"
- val LogCleanupPolicyProp = "log.cleanup.policy"
- val LogCleanerThreadsProp = "log.cleaner.threads"
- val LogCleanerIoMaxBytesPerSecondProp = "log.cleaner.io.max.bytes.per.second"
- val LogCleanerDedupeBufferSizeProp = "log.cleaner.dedupe.buffer.size"
- val LogCleanerIoBufferSizeProp = "log.cleaner.io.buffer.size"
- val LogCleanerDedupeBufferLoadFactorProp =
"log.cleaner.io.buffer.load.factor"
- val LogCleanerBackoffMsProp = "log.cleaner.backoff.ms"
- val LogCleanerMinCleanRatioProp = "log.cleaner.min.cleanable.ratio"
- val LogCleanerEnableProp = "log.cleaner.enable"
- val LogCleanerDeleteRetentionMsProp = "log.cleaner.delete.retention.ms"
- val LogCleanerMinCompactionLagMsProp = "log.cleaner.min.compaction.lag.ms"
- val LogCleanerMaxCompactionLagMsProp = "log.cleaner.max.compaction.lag.ms"
- val LogIndexSizeMaxBytesProp = "log.index.size.max.bytes"
- val LogIndexIntervalBytesProp = "log.index.interval.bytes"
- val LogFlushIntervalMessagesProp = "log.flush.interval.messages"
- val LogDeleteDelayMsProp = "log.segment.delete.delay.ms"
- val LogFlushSchedulerIntervalMsProp = "log.flush.scheduler.interval.ms"
- val LogFlushIntervalMsProp = "log.flush.interval.ms"
- val LogFlushOffsetCheckpointIntervalMsProp =
"log.flush.offset.checkpoint.interval.ms"
- val LogFlushStartOffsetCheckpointIntervalMsProp =
"log.flush.start.offset.checkpoint.interval.ms"
- val LogPreAllocateProp = "log.preallocate"
+ val LogDirsProp = LogConfigPrefix + "dirs"
+ val LogDirProp = LogConfigPrefix + "dir"
+ val LogSegmentBytesProp = LogConfigPrefix + "segment.bytes"
+
+ val LogRollTimeMillisProp = LogConfigPrefix + "roll.ms"
+ val LogRollTimeHoursProp = LogConfigPrefix + "roll.hours"
+
+ val LogRollTimeJitterMillisProp = LogConfigPrefix + "roll.jitter.ms"
+ val LogRollTimeJitterHoursProp = LogConfigPrefix + "roll.jitter.hours"
+
+ val LogRetentionTimeMillisProp = LogConfigPrefix + "retention.ms"
+ val LogRetentionTimeMinutesProp = LogConfigPrefix + "retention.minutes"
+ val LogRetentionTimeHoursProp = LogConfigPrefix + "retention.hours"
+
+ val LogRetentionBytesProp = LogConfigPrefix + "retention.bytes"
+ val LogCleanupIntervalMsProp = LogConfigPrefix +
"retention.check.interval.ms"
+ val LogCleanupPolicyProp = LogConfigPrefix + "cleanup.policy"
+ val LogCleanerThreadsProp = LogConfigPrefix + "cleaner.threads"
+ val LogCleanerIoMaxBytesPerSecondProp = LogConfigPrefix +
"cleaner.io.max.bytes.per.second"
+ val LogCleanerDedupeBufferSizeProp = LogConfigPrefix +
"cleaner.dedupe.buffer.size"
+ val LogCleanerIoBufferSizeProp = LogConfigPrefix + "cleaner.io.buffer.size"
+ val LogCleanerDedupeBufferLoadFactorProp = LogConfigPrefix +
"cleaner.io.buffer.load.factor"
+ val LogCleanerBackoffMsProp = LogConfigPrefix + "cleaner.backoff.ms"
+ val LogCleanerMinCleanRatioProp = LogConfigPrefix +
"cleaner.min.cleanable.ratio"
+ val LogCleanerEnableProp = LogConfigPrefix + "cleaner.enable"
+ val LogCleanerDeleteRetentionMsProp = LogConfigPrefix +
"cleaner.delete.retention.ms"
+ val LogCleanerMinCompactionLagMsProp = LogConfigPrefix +
"cleaner.min.compaction.lag.ms"
+ val LogCleanerMaxCompactionLagMsProp = LogConfigPrefix +
"cleaner.max.compaction.lag.ms"
+ val LogIndexSizeMaxBytesProp = LogConfigPrefix + "index.size.max.bytes"
+ val LogIndexIntervalBytesProp = LogConfigPrefix + "index.interval.bytes"
+ val LogFlushIntervalMessagesProp = LogConfigPrefix +
"flush.interval.messages"
+ val LogDeleteDelayMsProp = LogConfigPrefix + "segment.delete.delay.ms"
+ val LogFlushSchedulerIntervalMsProp = LogConfigPrefix +
"flush.scheduler.interval.ms"
+ val LogFlushIntervalMsProp = LogConfigPrefix + "flush.interval.ms"
+ val LogFlushOffsetCheckpointIntervalMsProp = LogConfigPrefix +
"flush.offset.checkpoint.interval.ms"
+ val LogFlushStartOffsetCheckpointIntervalMsProp = LogConfigPrefix +
"flush.start.offset.checkpoint.interval.ms"
+ val LogPreAllocateProp = LogConfigPrefix + "preallocate"
Review comment:
This seems a bit unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
