feyman2016 commented on pull request #10377:
URL: https://github.com/apache/kafka/pull/10377#issuecomment-860202376
@rajinisivaram Sorry for the late reply, I tried to set the
`FinalizedFeatures` and `SupportedFeatures` to `"ignorable": true` and modified
the `BrokerFeatures.createDefault()` as below, and the test won't complain now.
But since the versioning scheme is not being used and
`BrokerFeatures.createDefault()` is still empty now, I doubt the necessity for
this PR, what do you think? (More background: The original purpose of this PR
is KAFKA-9689, but now 9689 is on-hold.)
```
object BrokerFeatures extends Logging {
def createDefault(): BrokerFeatures = { val featureMap = Map("Sample" ->
new SupportedVersionRange(1,3)).asJava
val supportedFeatures = Features.supportedFeatures(featureMap)
new BrokerFeatures(supportedFeatures)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
