hachikuji commented on a change in pull request #10786:
URL: https://github.com/apache/kafka/pull/10786#discussion_r651378054
##########
File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java
##########
@@ -85,6 +85,20 @@ public OffsetAndEpoch snapshotId() {
return snapshot.snapshotId();
}
+ /**
+ * Returns the last log offset which is represented in the snapshot.
+ */
+ public long lastOffsetFromLog() {
Review comment:
Yeah, makes sense. I was sort of considering if it would be useful to
have a `SnapshotId` object. Currently we use `OffsetAndEpoch` in other cases,
but maybe a separate object would let us have better names. It would also let
us define inclusive and exclusive methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
