lbradstreet commented on a change in pull request #10754:
URL: https://github.com/apache/kafka/pull/10754#discussion_r651822091
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -337,6 +337,9 @@ class Log(@volatile private var _dir: File,
}
} else if (keepPartitionMetadataFile) {
_topicId.foreach(partitionMetadataFile.write)
+ } else {
Review comment:
This was a pre-existing issue but should we extract this whole if else
block to a method? It's also a little bit easy to miss that it's setting the
`_topicid` in
https://github.com/apache/kafka/pull/10754/files#diff-eeafed82ed6a8600c397b108787fdf31e03191b0a192774a65c127d0d26edc44L330.
Maybe that could benefit from an empty line prior to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
