satishd commented on a change in pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#discussion_r654091419
##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -301,6 +350,16 @@ object LogConfig {
FollowerReplicationThrottledReplicasDoc,
FollowerReplicationThrottledReplicasProp)
.define(MessageDownConversionEnableProp, BOOLEAN,
Defaults.MessageDownConversionEnable, LOW,
MessageDownConversionEnableDoc,
KafkaConfig.LogMessageDownConversionEnableProp)
+
+ // RemoteLogStorageEnableProp, LocalLogRetentionMsProp,
LocalLogRetentionBytesProp do not have server default
+ // config names.
Review comment:
@junrao As we discussed offline we wanted to enable cluster level
configs when the feature is complete. Filed
[KAFKA-12969](https://issues.apache.org/jira/browse/KAFKA-12969) for tracking
this change.
##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -301,6 +350,16 @@ object LogConfig {
FollowerReplicationThrottledReplicasDoc,
FollowerReplicationThrottledReplicasProp)
.define(MessageDownConversionEnableProp, BOOLEAN,
Defaults.MessageDownConversionEnable, LOW,
MessageDownConversionEnableDoc,
KafkaConfig.LogMessageDownConversionEnableProp)
+
+ // RemoteLogStorageEnableProp, LocalLogRetentionMsProp,
LocalLogRetentionBytesProp do not have server default
+ // config names.
Review comment:
@junrao As we discussed offline we wanted to enable cluster level
configs when the feature is complete. Filed
[KAFKA-12969](https://issues.apache.org/jira/browse/KAFKA-12969) for tracking
this change.
##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -301,6 +350,16 @@ object LogConfig {
FollowerReplicationThrottledReplicasDoc,
FollowerReplicationThrottledReplicasProp)
.define(MessageDownConversionEnableProp, BOOLEAN,
Defaults.MessageDownConversionEnable, LOW,
MessageDownConversionEnableDoc,
KafkaConfig.LogMessageDownConversionEnableProp)
+
+ // RemoteLogStorageEnableProp, LocalLogRetentionMsProp,
LocalLogRetentionBytesProp do not have server default
+ // config names.
Review comment:
@junrao As we discussed offline we wanted to enable cluster level
configs when the feature is complete. Filed KAFKA-12969 for tracking this
change.
##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -301,6 +350,16 @@ object LogConfig {
FollowerReplicationThrottledReplicasDoc,
FollowerReplicationThrottledReplicasProp)
.define(MessageDownConversionEnableProp, BOOLEAN,
Defaults.MessageDownConversionEnable, LOW,
MessageDownConversionEnableDoc,
KafkaConfig.LogMessageDownConversionEnableProp)
+
+ // RemoteLogStorageEnableProp, LocalLogRetentionMsProp,
LocalLogRetentionBytesProp do not have server default
+ // config names.
Review comment:
@junrao As we discussed offline we wanted to enable cluster level
configs when the feature is complete. Filed KAFKA-12969 for tracking this
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
