jlprat commented on a change in pull request #10840: URL: https://github.com/apache/kafka/pull/10840#discussion_r657138308
########## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskMetadataImplTest.java ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor.internals; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.streams.TaskMetadata; +import org.apache.kafka.streams.processor.TaskId; +import org.junit.Before; +import org.junit.Test; + +import java.util.Collection; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +import static org.apache.kafka.common.utils.Utils.mkEntry; +import static org.apache.kafka.common.utils.Utils.mkMap; +import static org.apache.kafka.common.utils.Utils.mkSet; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertNotEquals; + + +public class TaskMetadataImplTest { + + public static final TaskId TASK_ID = new TaskId(1, 2); + public static final TopicPartition TP_0 = new TopicPartition("t", 0); + public static final TopicPartition TP_1 = new TopicPartition("t", 1); + public static final Set<TopicPartition> TOPIC_PARTITIONS = mkSet(TP_0, TP_1); + public static final Map<TopicPartition, Long> COMMITTED_OFFSETS = mkMap(mkEntry(TP_1, 1L), mkEntry(TP_1, 2L)); + public static final Map<TopicPartition, Long> END_OFFSETS = mkMap(mkEntry(TP_1, 1L), mkEntry(TP_1, 3L)); + public static final Optional<Long> TIME_CURRENT_IDLING_STARTED = Optional.of(3L); + + private TaskMetadata taskMetadata; + + @Before + public void setUp() { + taskMetadata = new TaskMetadataImpl( + TASK_ID, + TOPIC_PARTITIONS, + COMMITTED_OFFSETS, + END_OFFSETS, + TIME_CURRENT_IDLING_STARTED); + } + + @Test + public void shouldNotAllowModificationOfInternalStateViaGetters() { + assertTrue(isUnmodifiable(taskMetadata.topicPartitions())); + assertTrue(isUnmodifiable(taskMetadata.committedOffsets())); + assertTrue(isUnmodifiable(taskMetadata.endOffsets())); + } + + @Test + public void shouldFollowEqualsAndHasCodeContract() { Review comment: @cadonna For hash code and equals contract validation, I decided to keep it under one single test, and validate the positive cases and any of the reasons why it might fall into the negative case. Please note that objects differing only on committed offsets, end offsets, and/or time curring idling started will be considered equals. ########## File path: streams/src/test/java/org/apache/kafka/streams/state/StreamsMetadataTest.java ########## @@ -55,6 +62,63 @@ public void shouldNotAllowModificationOfInternalStateViaGetters() { assertTrue(isUnmodifiable(streamsMetadata.standbyStateStoreNames())); } + @Test + public void shouldFollowHashCodeAndEqualsContract() { Review comment: @cadonna For hash code and equals contract validation, I decided to keep it under one single test, and validate the positive case and any of the reasons why it might fall into the negative case. ########## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ThreadMetadataImplTest.java ########## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.processor.internals; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.streams.TaskMetadata; +import org.apache.kafka.streams.ThreadMetadata; +import org.apache.kafka.streams.processor.TaskId; +import org.junit.Before; +import org.junit.Test; + +import java.util.Collection; +import java.util.Optional; +import java.util.Set; + +import static org.apache.kafka.common.utils.Utils.mkEntry; +import static org.apache.kafka.common.utils.Utils.mkMap; +import static org.apache.kafka.common.utils.Utils.mkSet; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.junit.jupiter.api.Assertions.assertNotEquals; + +public class ThreadMetadataImplTest { + + public static final String THREAD_NAME = "thread name"; + public static final String THREAD_STATE = "thread state"; + public static final String MAIN_CONSUMER_CLIENT_ID = "main Consumer ClientID"; + public static final String RESTORE_CONSUMER_CLIENT_ID = "restore Consumer ClientID"; + public static final String CLIENT_ID_1 = "client Id 1"; + public static final String CLIENT_ID_2 = "client Id 2"; + public static final Set<String> PRODUCER_CLIENT_IDS = mkSet(CLIENT_ID_1, CLIENT_ID_2); + public static final TaskId TASK_ID_0 = new TaskId(1, 2); + public static final TaskId TASK_ID_1 = new TaskId(1, 1); + public static final TopicPartition TP_0_0 = new TopicPartition("t", 0); + public static final TopicPartition TP_1_0 = new TopicPartition("t", 1); + public static final TopicPartition TP_0_1 = new TopicPartition("t", 2); + public static final TopicPartition TP_1_1 = new TopicPartition("t", 3); + public static final TaskMetadata TM_0 = new TaskMetadataImpl( + TASK_ID_0, + mkSet(TP_0_0, TP_1_0), + mkMap(mkEntry(TP_0_0, 1L), mkEntry(TP_1_0, 2L)), + mkMap(mkEntry(TP_0_0, 1L), mkEntry(TP_1_0, 2L)), + Optional.of(3L)); + public static final TaskMetadata TM_1 = new TaskMetadataImpl( + TASK_ID_1, + mkSet(TP_0_1, TP_1_1), + mkMap(mkEntry(TP_0_1, 1L), mkEntry(TP_1_1, 2L)), + mkMap(mkEntry(TP_0_1, 1L), mkEntry(TP_1_1, 2L)), + Optional.of(3L)); + public static final Set<TaskMetadata> STANDBY_TASKS = mkSet(TM_0, TM_1); + public static final Set<TaskMetadata> ACTIVE_TASKS = mkSet(TM_1); + public static final String ADMIN_CLIENT_ID = "admin ClientID"; + + private ThreadMetadata threadMetadata; + + @Before + public void setUp() { + threadMetadata = new ThreadMetadataImpl( + THREAD_NAME, + THREAD_STATE, + MAIN_CONSUMER_CLIENT_ID, + RESTORE_CONSUMER_CLIENT_ID, + PRODUCER_CLIENT_IDS, + ADMIN_CLIENT_ID, + ACTIVE_TASKS, + STANDBY_TASKS + ); + } + + @Test + public void shouldNotAllowModificationOfInternalStateViaGetters() { + assertTrue(isUnmodifiable(threadMetadata.producerClientIds())); + assertTrue(isUnmodifiable(threadMetadata.activeTasks())); + assertTrue(isUnmodifiable(threadMetadata.standbyTasks())); + } + + @Test + public void shouldFollowHashCodeAndEqualsContract() { Review comment: @cadonna For hash code and equals contract validation, I decided to keep it under one single test, and validate the positive case and any of the reasons why it might fall into the negative case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
