ccding commented on a change in pull request #10763:
URL: https://github.com/apache/kafka/pull/10763#discussion_r657558091
##########
File path: core/src/main/scala/kafka/log/LogLoader.scala
##########
@@ -167,21 +245,14 @@ object LogLoader extends Logging {
* in place of existing segment(s). For log splitting, we know that any
.swap file whose base offset is higher than
* the smallest offset .clean file could be part of an incomplete split
operation. Such .swap files are also deleted
* by this method.
+ *
* @param params The parameters for the log being loaded from disk
- * @return Set of .swap files that are valid to be swapped in as segment
files
+ * @return Set of .swap files that are valid to be swapped in as segment
files and index files
Review comment:
No, we are not renaming .cleaned files to .swap files due to KAFKA-6264.
I forgot to update the description of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
