jolshan commented on a change in pull request #10892:
URL: https://github.com/apache/kafka/pull/10892#discussion_r660250731
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DeleteTopicsResult.java
##########
@@ -30,24 +31,62 @@
*/
@InterfaceStability.Evolving
public class DeleteTopicsResult {
- final Map<String, KafkaFuture<Void>> futures;
+ private Map<String, KafkaFuture<Void>> nameFutures;
+ private Map<Uuid, KafkaFuture<Void>> topicIdFutures;
- protected DeleteTopicsResult(Map<String, KafkaFuture<Void>> futures) {
- this.futures = futures;
+ protected DeleteTopicsResult() {}
Review comment:
Ah I remember the issue with that being private. There is a test that
extends this class.
> @hachikuji I originally wanted the constructor for DeleteTopicsResult to
be private, but InternalTopicManagerTest required creating a subclass.
https://github.com/apache/kafka/pull/10892#issuecomment-862876282
The issue with just using the static method is that it is protected in the
class. So the options are to either make the class protected (as is now), make
the static method public, or change the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
