showuon commented on a change in pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#discussion_r661098484
##########
File path: core/src/main/scala/kafka/admin/ConfigCommand.scala
##########
@@ -68,7 +68,7 @@ object ConfigCommand extends Config {
val BrokerDefaultEntityName = ""
val BrokerLoggerConfigType = "broker-loggers"
val BrokerSupportedConfigTypes = ConfigType.all :+ BrokerLoggerConfigType
- val ZkSupportedConfigTypes = ConfigType.all
+ val ZkSupportedConfigTypes = Seq(ConfigType.User, ConfigType.Broker)
Review comment:
If you're saying this comment:
> // Dynamic broker configs can only be updated using the new AdminClient
once brokers have started
// so that configs may be fully validated. Prior to starting brokers,
updates may be performed using
// ZooKeeper for bootstrapping. This allows all password configs to be
stored encrypted in ZK,
// avoiding clear passwords in server.properties. For consistency with
older versions, quota-related
// broker configs can still be updated using ZooKeeper at any time.
I checked and confirmed that it is saying these 3 configs of "broker" type
(not "quota" type):
```
val BrokerConfigsUpdatableUsingZooKeeperWhileBrokerRunning = Set(
DynamicConfig.Broker.LeaderReplicationThrottledRateProp,
DynamicConfig.Broker.FollowerReplicationThrottledRateProp,
DynamicConfig.Broker.ReplicaAlterLogDirsIoMaxBytesPerSecondProp)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
