izzyacademy commented on a change in pull request #10926: URL: https://github.com/apache/kafka/pull/10926#discussion_r661486188
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java ########## @@ -177,7 +204,9 @@ public long size() { * @param afterWindowEnd The grace period to admit out-of-order events to a window. * @return this updated builder * @throws IllegalArgumentException if the {@code afterWindowEnd} is negative of can't be represented as {@code long milliseconds} + * @deprecated since 3.0 Use {@link #ofTimeDifferenceWithNoGrace(Duration)} instead */ + @Deprecated public JoinWindows grace(final Duration afterWindowEnd) throws IllegalArgumentException { Review comment: @mjsax I believe those came with your changes in the PR you merged into trunk. @mjsax, @ableegoldman, please let me know what you think and I can address that as well in the future JIRA ticket. It could require updating all the unit tests where org.apache.kafka.streams.kstream.JoinWindows.grace() is invoked so that looks like a significant undertaking given today is the cutoff date for merging the feature. Once you let me know what you would like to do, I will create a JIRA ticket and work on that update, the javadocs and the unit tests. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org