[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

[GitBox]

showuon commented on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-871984330


   @ijuma , I've updated the PR:
   1. remove the support to update quota related broker configs using ZooKeeper.
   2. require `zk-tls-config-file` option when `zookeeper` is provided. 
   I didn't block the `user` `describe` action before because the `user` can 
still describe to check SCRAM credential status. But you're right, we should 
not allow quota related update/describe. So, I add a required option 
`zk-tls-config-file` option when `zookeeper` is provided. This way, we can make 
sure it's doing SCRAM credential update or password update before broker 
started (both operation need `zk-tls-config-file` option)
   
   
![image](https://user-images.githubusercontent.com/43372967/124080900-77c37f00-da7d-11eb-8b3e-d42684775557.png)
   
   3. update tests
   
   Thank you.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org