jsancio commented on a change in pull request #10946:
URL: https://github.com/apache/kafka/pull/10946#discussion_r662610242
##########
File path: metadata/src/test/java/org/apache/kafka/metalog/LocalLogManager.java
##########
@@ -198,7 +207,12 @@ synchronized void unregisterLogManager(LocalLogManager
logManager) {
}
}
- synchronized long tryAppend(int nodeId, long epoch, LocalBatch batch) {
+ synchronized long tryAppend(int nodeId, int epoch,
List<ApiMessageAndVersion> batch) {
+ // No easy access to the concept of time. Use the base offset as
the append timestamp
Review comment:
Good idea. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
