xvrl commented on a change in pull request #10937:
URL: https://github.com/apache/kafka/pull/10937#discussion_r662677742



##########
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##########
@@ -455,7 +455,13 @@ object MirrorMaker extends Logging with KafkaMetricsGroup {
       .defaultsTo(1)
 
     val whitelistOpt = parser.accepts("whitelist",
-      "Whitelist of topics to mirror.")
+      "DEPRECATED, use --include instead; ignored if --include specified. List 
of included topics to mirror.")

Review comment:
       The term "included" seems redundant ```suggestion
         "DEPRECATED, use --include instead; ignored if --include specified. 
List of topics to mirror.")
   ```

##########
File path: core/src/main/scala/kafka/tools/MirrorMaker.scala
##########
@@ -455,7 +455,13 @@ object MirrorMaker extends Logging with KafkaMetricsGroup {
       .defaultsTo(1)
 
     val whitelistOpt = parser.accepts("whitelist",
-      "Whitelist of topics to mirror.")
+      "DEPRECATED, use --include instead; ignored if --include specified. List 
of included topics to mirror.")

Review comment:
       The term "included" seems redundant
   ```suggestion
         "DEPRECATED, use --include instead; ignored if --include specified. 
List of topics to mirror.")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to