skaundinya15 commented on a change in pull request #10962:
URL: https://github.com/apache/kafka/pull/10962#discussion_r663419025
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java
##########
@@ -174,6 +319,10 @@ public boolean isAllPartitions() {
return data.topics() == ALL_TOPIC_PARTITIONS;
}
+ public List<OffsetFetchRequestTopics> isAllPartitionsForGroup() {
Review comment:
So earlier I had it return whether or not a specific group had all
partitions, but then ended up changing the implementation as I realized I
wasn't able to cache the group to topic partition map locally, and figured it
was not very efficient to always build up the group to topic partition map and
then return whether or not it equals `ALL_TOPIC_PARTITIONS_BATCH`. For this
reason I ended up just returning what the value of `ALL_TOPIC_PARTITIONS_BATCH`
was. I agree we can definitely use a better name here, so perhaps I can change
it to `allTopicPartitionsBatch`? Or perhaps there is a better way of figuring
out if a specific group is requesting all topic partitions to fetch offsets for
- any ideas on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
