dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r664308959
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
##########
@@ -65,6 +65,20 @@ public Builder(List<String> topics, boolean
allowAutoTopicCreation) {
this(topics, allowAutoTopicCreation,
ApiKeys.METADATA.oldestVersion(), ApiKeys.METADATA.latestVersion());
}
+ public Builder(List<Uuid> topicIds) {
+ super(ApiKeys.METADATA, ApiKeys.METADATA.oldestVersion(),
ApiKeys.METADATA.latestVersion());
+ MetadataRequestData data = new MetadataRequestData();
+ if (topicIds == null)
+ data.setTopics(null);
+ else {
+ topicIds.forEach(topicId -> data.topics().add(new
MetadataRequestTopic().setTopicId(topicId).setName("")));
Review comment:
This is old code since we do not support null names firstly, now we can
remove this useless code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
