thomaskwscott commented on a change in pull request #10960:
URL: https://github.com/apache/kafka/pull/10960#discussion_r664377980
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1345,8 +1345,9 @@ class Log(@volatile private var _dir: File,
val latestTimestampSegment = segmentsCopy.maxBy(_.maxTimestampSoFar)
val latestEpochOpt =
leaderEpochCache.flatMap(_.latestEpoch).map(_.asInstanceOf[Integer])
val epochOptional = Optional.ofNullable(latestEpochOpt.orNull)
- Some(new TimestampAndOffset(latestTimestampSegment.maxTimestampSoFar,
- latestTimestampSegment.offsetOfMaxTimestampSoFar,
+ val latestTimestampAndOffset =
latestTimestampSegment.maxTimestampAndOffsetSoFar
+ Some(new TimestampAndOffset(latestTimestampAndOffset.timestamp,
+ latestTimestampAndOffset.offset,
Review comment:
I had a check through and can't see any other copy instances
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
