dajac commented on a change in pull request #10955:
URL: https://github.com/apache/kafka/pull/10955#discussion_r664771393



##########
File path: 
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientTestUtils.java
##########
@@ -102,4 +104,15 @@ public static DescribeTopicsResult 
describeTopicsResult(Map<String, TopicDescrip
     public static ListConsumerGroupOffsetsResult 
listConsumerGroupOffsetsResult(Map<TopicPartition, OffsetAndMetadata> offsets) {
         return new 
ListConsumerGroupOffsetsResult(KafkaFuture.completedFuture(offsets));
     }
+
+    /**
+     * Used for benchmark. KafkaAdminClient.getListOffsetsCalls is only 
accessible
+     * from within the admin package.
+     */
+    public static List<KafkaAdminClient.Call> 
getListOffsetsCalls(KafkaAdminClient adminClient, 

Review comment:
       Could we align the arguments?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to