ableegoldman commented on pull request #10903: URL: https://github.com/apache/kafka/pull/10903#issuecomment-875181165
> So, in this PR, I've added 1 test to test it: testMultiConsumerDefaultAssignorAndVerifyAssignment Thanks Luke, but I actually meant something simpler (and stupider) that directly verifies that the chosen assignor is the RangeAssignor, rather than inferring it from the assignment that's produced. Like something in ConsumerConfigTest, or KafkaConsumerTest. Does that make sense? I just think we want to have both a test: a more complicated test that validates what we actually care about, the resulting assignment, but also a plain dumb test that we can be 100% sure will break if/when the default assignor is changed, no matter what it gets changed to (ie even if the new assignor happens to produce the same assignment as the RangeAssignor in some cases) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
