satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r664983511
##########
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##########
@@ -51,6 +58,7 @@
*/
public class TopicBasedRemoteLogMetadataManager implements
RemoteLogMetadataManager {
private static final Logger log =
LoggerFactory.getLogger(TopicBasedRemoteLogMetadataManager.class);
+ private static final long INITIALIZATION_RETRY_INTERVAL_MS = 30000L;
Review comment:
I prefer adding L for longs, which I missed at other declaration. afaik,
that does not cause any issues as it gets automatically converted via a
widening conversion to a `long`. The compiler takes care of not allowing
numbers that may get truncated from `int` to `long` widening. Thanks for
catching it, I will make it consistent by adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
