cmccabe commented on a change in pull request #10753:
URL: https://github.com/apache/kafka/pull/10753#discussion_r667727058
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -1111,19 +1111,19 @@ private QuorumController(LogContext logContext,
}
return appendWriteEvent("alterPartitionReassignments",
time.nanoseconds() + NANOSECONDS.convert(request.timeoutMs(),
MILLISECONDS),
- () -> {
- throw new UnsupportedOperationException();
- });
+ () -> replicationControl.alterPartitionReassignments(request));
}
@Override
public CompletableFuture<ListPartitionReassignmentsResponseData>
listPartitionReassignments(ListPartitionReassignmentsRequestData
request) {
+ if (request.topics() != null && request.topics().isEmpty()) {
+ return CompletableFuture.completedFuture(
+ new
ListPartitionReassignmentsResponseData().setErrorMessage(null));
Review comment:
Unfortunately, the default is not null. I could change the default, but
I'd have to change a bunch of other code, so I left it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
