tombentley commented on a change in pull request #11006:
URL: https://github.com/apache/kafka/pull/11006#discussion_r668466658
##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -312,7 +312,15 @@ class LogManager(logDirs: Seq[File],
val logDirAbsolutePath = dir.getAbsolutePath
var hadCleanShutdown: Boolean = false
try {
- val pool = Executors.newFixedThreadPool(numRecoveryThreadsPerDataDir)
+ val pool = Executors.newFixedThreadPool(numRecoveryThreadsPerDataDir,
new ThreadFactory {
+ private val factory = Executors.defaultThreadFactory()
+ private val threadNumber = new AtomicInteger(1)
Review comment:
Only as a means of having unique names when >1 thread per log dir. You
can't really infer anything from the number though, so I could remove it if you
want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
