showuon opened a new pull request #11035:
URL: https://github.com/apache/kafka/pull/11035
Some issues found in the RemoveMembersFromConsumerGroupHandler:
1. if coordinator errors is put in the member, we don't do retry. Fix it and
add tests
This is the old handle response logic. FYR:
```java
void handleResponse(AbstractResponse abstractResponse) {
final LeaveGroupResponse response = (LeaveGroupResponse)
abstractResponse;
// If coordinator changed since we fetched it, retry
// note here: we'll collect all errors in group error and member
errors, to check if if we need to retry
if (ConsumerGroupOperationContext.hasCoordinatorMoved(response)) {
Call call = getRemoveMembersFromGroupCall(context, members);
rescheduleFindCoordinatorTask(context, () -> call, this);
return;
}
if (handleGroupRequestError(response.topLevelError(),
context.future()))
return;
final Map<MemberIdentity, Errors> memberErrors = new HashMap<>();
for (MemberResponse memberResponse : response.memberResponses()) {
memberErrors.put(new MemberIdentity()
.setMemberId(memberResponse.memberId())
.setGroupInstanceId(memberResponse.groupInstanceId()),
Errors.forCode(memberResponse.errorCode()));
}
context.future().complete(memberErrors);
}
```
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
