OmniaGM commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r668733381



##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -191,9 +191,15 @@ object ConsoleConsumer extends Logging {
       .withRequiredArg
       .describedAs("topic")
       .ofType(classOf[String])
-    val whitelistOpt = parser.accepts("whitelist", "Regular expression 
specifying whitelist of topics to include for consumption.")
+    val whitelistOpt = parser.accepts("whitelist",
+      "DEPRECATED, use --include instead; ignored if --include specified. 
Regular expression specifying list of topics to include for consumption.")

Review comment:
       I think with some other deprecated arguments we simply ignore the 
deprecated if the new one specified. for example 
   - `--broker-list` and `--bootstrap-server` in ConsoleProducer, 
VerifiableConsumer, VerifiableProducer and GetOffsetShell
   And the scripts doesn't fail if both deprecated and new one existed.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to