OmniaGM commented on a change in pull request #11008:
URL: https://github.com/apache/kafka/pull/11008#discussion_r668793973
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -315,11 +321,23 @@ object ConsoleConsumer extends Logging {
formatter.configure(formatterArgs.asScala.asJava)
- val topicOrFilterOpt = List(topicOpt, whitelistOpt).filter(options.has)
- if (topicOrFilterOpt.size != 1)
- CommandLineUtils.printUsageAndDie(parser, "Exactly one of
whitelist/topic is required.")
+ val filterOpts = List(includeOpt, whitelistOpt).filter(options.has)
+ if (filterOpts.size == 2) {
+ CommandLineUtils.warn("--whitelist is DEPRECATED and ignored if
--include specified.")
Review comment:
I think if someone started to use `--include` they already noticed the
usage help message which explained the ignoring part. But I got what you are
saying. The other point is we already merged MirrorMaker script with only
ignoring in this pr #10937 do we need to raise another one to handle this in
the same way for consistency? (keeping in mind that KIP-629 suppose to be part
of 3.0.0 release and the code freeze is tomorrow July 14th, 2021)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
