[
https://issues.apache.org/jira/browse/KAFKA-13081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380251#comment-17380251
]
A. Sophie Blee-Goldman commented on KAFKA-13081:
------------------------------------------------
Personally I would probably advocate for just applying the two fixes to 2.8
rather than porting over the full set of improvements and refactorings. While
the improvements are great to have, they're not strictly necessary and
relatively complex, so porting them back carries some risk in case of
as-yet-undiscovered bugs that were introduced during the large-scale
refactoring of this assignor. Given that it's hard to be 100% confident in the
correctness of such a complicated algorithm, regardless of how good the test
coverage is, I would prefer to just apply the minimal required fixes and leave
2.8 as a "safe" branch. That way we can fall back to it in case of unexpected
issues in the 3.0 assignor, and recommend users who want to downgrade to the
last stable version with a good "cooperative-sticky"/"sticky" assignor they can
continue to use until the new assignor is stabilized.
Just my 2 cents
> Port sticky assignor fixes (KAFKA-12984) back to 2.8
> ----------------------------------------------------
>
> Key: KAFKA-13081
> URL: https://issues.apache.org/jira/browse/KAFKA-13081
> Project: Kafka
> Issue Type: Bug
> Reporter: A. Sophie Blee-Goldman
> Assignee: Luke Chen
> Priority: Blocker
> Fix For: 2.8.1
>
>
> We should make sure that fix #1 and #2 of
> [#10985|https://github.com/apache/kafka/pull/10985] make it back to the 2.8
> sticky assignor, since it's pretty much impossible to smoothly cherrypick
> that commit from 3.0 to 2.8 due to all the recent improvements and
> refactoring in the AbstractStickyAssignor. Either we can just extract and
> apply those two fixes to 2.8 directly, or go back and port all the commits
> that made this cherrypick difficult over to 2.8 as well. If we do so then
> cherrypicking the original commit should be easy.
> See [this
> comment|https://github.com/apache/kafka/pull/10985#issuecomment-879521196]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
