showuon commented on a change in pull request #11026: URL: https://github.com/apache/kafka/pull/11026#discussion_r669553529
########## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/ListConsumerGroupOffsetsHandler.java ########## @@ -110,41 +112,97 @@ public String apiName() { groupOffsetsListing.put(topicPartition, new OffsetAndMetadata(offset, leaderEpoch, metadata)); } } else { - log.warn("Skipping return offset for {} due to error {}.", topicPartition, error); + handlePartitionError(groupId, topicPartition, error, groupsToUnmap, groupsToRetry); } } completed.put(groupId, groupOffsetsListing); } - return new ApiResult<>(completed, failed, unmapped); + + if (groupsToUnmap.isEmpty() && groupsToRetry.isEmpty()) { + return new ApiResult<>( + completed, Review comment: No, we can't do that because the `completed` here could be `empty map`. If we put `Collections.singletonMap(groupId, groupOffsetsListing)`, it'll always not empty. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org