lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r669851397
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##########
@@ -51,12 +57,12 @@ public boolean assign(final Map<UUID, ClientState> clients,
final SortedSet<TaskId> statefulTasks = new TreeSet<>(statefulTaskIds);
final TreeMap<UUID, ClientState> clientStates = new TreeMap<>(clients);
- assignActiveStatefulTasks(clientStates, statefulTasks);
+ final Map<TaskId, UUID> statefulTasksClientMappings =
assignActiveStatefulTasks(clientStates, statefulTasks);
Review comment:
I tried to avoid unnecessary iterations. With that we would have to do
separate iteration in the `ClientTagAwareStandbyTaskAssignor`, which felt
redundant, since `assignActiveStatefulTasks` can return necessary mapping since
it has to iterate over client states either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
