rondagostino commented on pull request #11066:
URL: https://github.com/apache/kafka/pull/11066#issuecomment-881063696
Maybe rename `ReplicaManagerMetricNamesTest` to `ClusterMetricNamesTest` so
that it isn't specific to `ReplicaManager`? We could define it like this:
```
@ClusterTest
def testMetrics(): Unit = {
checkReplicaManagerMetrics()
// checkWhateverOtherMetricsWeDecideToAddHereLater()
}
private def checkReplicaManagerMetrics() {
// same implementation as we have now
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
