jolshan opened a new pull request #11073:
URL: https://github.com/apache/kafka/pull/11073


   Cherry pick of 584213ed20d679b11206b67c5a65035347632f07
   
   Main difference is that we do not try to write to partition metadata file 
when initializing the Log. Since we only do so in checkOrSet topic ID and there 
is a small bug in that path, the benchmark attempts to run that method last -- 
so that the log is created and we can actually record the ID to write. 
   
   Some quick runs of the benchmarks --
   Master
   ```
   Benchmark                                   (numPartitions)  (useTopicIds)  
Mode  Cnt     Score   Error  Units
   PartitionCreationBench.makeFollower                    2000          false  
avgt    2  2576.278          ms/op
   PartitionCreationBench.makeFollower                    2000           true  
avgt    2  5378.075          ms/op
   ```
   
   PR
   ```
   Benchmark                                   (numPartitions)  (useTopicIds)  
Mode  Cnt     Score   Error  Units
   PartitionCreationBench.makeFollower                    2000          false  
avgt    2  2678.498          ms/op
   PartitionCreationBench.makeFollower                    2000           true  
avgt    2  2962.268          ms/op
   ```
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to