[GitHub] [kafka] ableegoldman commented on a change in pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

[GitBox]

ableegoldman commented on a change in pull request #10921:
URL: https://github.com/apache/kafka/pull/10921#discussion_r672765942



##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1081,6 +1079,7 @@ private int getNumStreamThreads(final boolean 
hasGlobalTopology) {
                             } else {
                                 log.info("Successfully removed {} in {}ms", 
streamThread.getName(), time.milliseconds() - startMs);
                                 threads.remove(streamThread);
+                                queryableStoreProvider.removeStoreProvider(new 
StreamThreadStateStoreProvider(streamThread));

Review comment:
       It seems a bit weird to have to create a `new 
StreamThreadStateStoreProvider(streamThread)` just to remove and existing 
`StreamThreadStateStoreProvider` from this -- can we maybe change it so that 
`#removeStoreProvider` accepts a `StreamThread` reference, or even just a 
`String streamThreadName`? And then store a map from name to 
`StreamThreadStateStoreProvider` or something -- WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org