jeqo commented on a change in pull request #11099:
URL: https://github.com/apache/kafka/pull/11099#discussion_r675036126
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableSourceTest.java
##########
@@ -156,7 +156,7 @@ public void kTableShouldLogAndMeterOnSkippedRecords() {
.filter(e -> e.getLevel().equals("WARN"))
.map(Event::getMessage)
.collect(Collectors.toList()),
- hasItem("Skipping record due to null key. topic=[topic]
partition=[0] offset=[0]")
+ hasItem("Skipping record due to null key. value=[value]
topic=[topic] partition=[0] offset=[0]")
Review comment:
> On another note, I guess we could add a test for the other (new) code
path when the metadata is absent. I'll leave it up to you.
Happy to add more tests. What I'm wondering is how to test scenarios where
no context is added 🤔 ? TopologyTestDriver allows to nullify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
