cmccabe commented on a change in pull request #11118:
URL: https://github.com/apache/kafka/pull/11118#discussion_r675850704
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -259,7 +259,7 @@ class Log(@volatile var logStartOffset: Long,
import kafka.log.Log._
- this.logIdent = s"[Log partition=$topicPartition, dir=$parentDir] "
+ this.logIdent = s"[Log partition=$topicPartition,
dir=${parentDir}${topicId.map(id => s", topicId=$id").getOrElse("")}] "
Review comment:
It seems like topicID will almost always be set to the empty string
here, since _topicId is (often?) not initialized until these lines below:
```
locally {
initializePartitionMetadata()
updateLogStartOffset(logStartOffset)
maybeIncrementFirstUnstableOffset()
initializeTopicId()
}
```
This might be better in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
