ableegoldman commented on pull request #10683: URL: https://github.com/apache/kafka/pull/10683#issuecomment-888514727
> I only have a concern about keeping track on the topology builders instead on the generated topologies that it may restrict how we want to optimize the topology generation process, but I also feel this is not closing the door anyways as we can still refactor this piece of logic in the future, so not a blocker for this PR after all. That's a fair point, however I think the TopologyMetadata/NamedTopology feature in general is pretty agnostic to whether the topologies have already been compiled or not, the only reason it tracks InternalTopologyBuilders is because that's where all the topology metadata currently resides. I think if we were to try any crazy optimizations on top of the current topology generation process it would require some refactoring to decouple the generated topology from the topology metadata, in which case we would likely have the metadata split out into a new, pre-topology compilation class. And then we would track that class instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
