guozhangwang opened a new pull request #11155:
URL: https://github.com/apache/kafka/pull/11155


   1. This test is taking two iterations since the firs iteration is designed 
to fail due to unknow topic leader. However both the timeout and the backoff 
are set to 50ms, while the actual SYSTEM time is used. This means we are likely 
to timeout before executing the second iteration. I thought about using a mock 
time but dropped that idea as it may forgo the purpose of this test, instead I 
set the backoff time to 10ms so that we are almost unlikely to hit this error 
anymore.
   
   2. Found a minor issue while fixing this which is that when we have 
non-empty not-ready topics, but the topics-to-create is empty (which is 
possible as the test 
shouldCreateTopicWhenTopicLeaderNotAvailableAndThenTopicNotFound itself 
illustrates), we still call an empty create-topic function. Though it does not 
incur any round-trip it would still waste some cycles, so I branched it off and 
hence also simplified some unit tests.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to